[U-Boot] [PATCH] phylib: Detect link on 10G devices correctly
Wolfgang Denk
wd at denx.de
Wed Jul 27 23:21:32 CEST 2011
Dear Andy Fleming,
In message <1305762259-5639-1-git-send-email-afleming at freescale.com> you wrote:
> gen10g_startup() had 2 bugs:
>
> 1) It had a boolean logic error in checking the MMD mask, and
> always checked all of them.
>
> 2) It checked devices which don't actually report link state, which
> meant that it would never believe the link was fully up.
>
> Fix the boolean logic, and then mask the MMD mask so only link-reporting
> devices are checked.
>
> Signed-off-by: Andy Fleming <afleming at freescale.com>
> Reported-by: Ed Swarthout <Ed.Swarthout at freescale.com>
> ---
>
> drivers/net/phy/generic_10g.c | 8 ++++++--
> include/linux/mdio.h | 8 ++++++++
> 2 files changed, 14 insertions(+), 2 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
WARNING: This Product Attracts Every Other Piece of Matter in the
Universe, Including the Products of Other Manufacturers, with a Force
Proportional to the Product of the Masses and Inversely Proportional
to the Distance Between Them.
More information about the U-Boot
mailing list