[U-Boot] [PATCH V4 3/5] nand spl: add NAND Library to new SPL

[Aneesh V]

Hi Scott,

On Thursday 28 July 2011 03:31 AM, Scott Wood wrote:
> On Wed, 27 Jul 2011 20:25:44 +0530
> "V, Aneesh"<aneesh at ti.com>  wrote:
>
>> Hi Simon, Scott,
>>
>> On Wed, Jul 27, 2011 at 2:52 PM, Simon Schwarz
>> <simonschwarzcor at googlemail.com>  wrote:
>>> Dear Scott Wood,
>>>
>>> On 07/26/2011 08:04 PM, Scott Wood wrote:
>>>> You're assuming all NAND SPLs will want nand_ecc -- this will not fit in
>>>> most current ones.
>>>
>>> True. I changed it to:
>>> ifdef CONFIG_SPL_BUILD
>>> COBJS-y += nand_spl.o
>>> ifdef CONFIG_OMAP34XX
>>
>> -ffunction-sections, -fdata-sections and --gc-sections are enabled globally
>> for SPL. Source files are #ifdef'ed out in Makefile's for SPL primarily to
>> reduce build time.
>
> Ah, right.
>
>> I would suggest to enable the super set of all files needed for all SPL's
>> in these Makefile's and not clutter it with any more #ifdef's
>
> It's not relevant for nand_ecc, but there will still be a cases where
> we'll want to select particular object files because we're selecting from
> alternatives that provide the same symbols, or where an object file has
> dependencies that are not met for this target.

Agree. Perhaps those should only be the cases where we need additional
'ifdef's

br,
Aneesh