[U-Boot] [PATCH] powerpc/eeprom: cleanup mac command

Wolfgang Denk wd at denx.de
Thu Jul 28 15:35:31 CEST 2011


Dear York Sun,

In message <1309457195-8475-1-git-send-email-yorksun at freescale.com> you wrote:
> Move mac command to board/freescale/common/sys_eeprom.c.
> Change the help message to be more helpful. Print argument format.
> Fix MAX_NUM_PORTS to comply with v1 NXID format.
> 
> Signed-off-by: York Sun <yorksun at freescale.com>

Why are you turning a generic, board and architecture independent
command into a FSL specific one?

This makes no sense to me, NAK.

>  board/freescale/common/sys_eeprom.c |   29 ++++++++++++++++++++-
>  common/Makefile                     |    1 -
>  common/cmd_mac.c                    |   49 -----------------------------------
>  3 files changed, 28 insertions(+), 51 deletions(-)
>  delete mode 100644 common/cmd_mac.c

In case you ever move / rename a file:  please supply the options so
git will detect the move / copy / rename.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can fool some of the people all of the time, and You can fool all
of the people some of the time, but You can't fool mom.


More information about the U-Boot mailing list