[U-Boot] [PATCH V3+] I2C: mxc_i2c rework
Wolfgang Denk
wd at denx.de
Thu Jul 28 16:29:01 CEST 2011
Dear Marek,
In message <4E1EB127.3040505 at denx.de> Heiko wrote:
> Hello Marek,
>
> Marek Vasut wrote:
> > Rewrite the mxc_i2c driver.
> > * This version is much closer to Linux implementation.
> > * Fixes IPG_PERCLK being incorrectly used as clock source
> > * Fixes behaviour of the driver on iMX51
> > * Clean up coding style a bit ;-)
> >
> > Based on commit: e39428d53d080ad2615b772d7f99d2a70c2aaab2
> > Date: Mon Jun 21 09:27:05 2010 +0200
> > i2c-imx: do not allow interruptions when waiting for I2C to complete
> >
> > Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> > ---
> > drivers/i2c/mxc_i2c.c | 424 +++++++++++++++++++++++++++++++++----------------
> > 1 files changed, 290 insertions(+), 134 deletions(-)
> >
> > V2: Convert register access to struct mxc_i2c_regs.
> >
> > V3: Update licensing info
> >
> > V3+: Add commit ID into commit message
>
> checkpatch says:
>
> ERROR: trailing statements should be on next line
> #143: FILE: drivers/i2c/mxc_i2c.c:130:
> + for (i = 0; i2c_clk_div[i][0] < div; i++);
>
> total: 1 errors, 0 warnings, 526 lines checked
>
> Can you fix this?
Are you going to send a fixed version any time soon?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
THIS IS A 100% MATTER PRODUCT: In the Unlikely Event That This
Merchandise Should Contact Antimatter in Any Form, a Catastrophic
Explosion Will Result.
More information about the U-Boot
mailing list