[U-Boot] [PATCH] arm: fix bd pointer dereference prior initialization

Chander Kashyap chander.kashyap at linaro.org
Fri Jul 29 05:53:57 CEST 2011


On 28 July 2011 14:34, Igor Grinberg <grinberg at compulab.co.il> wrote:
> gd->bd pointer has been used prior been initialized.
> Move the relevant code after the initialization.
>
> Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>
tested-by: Chander Kashyap <chander.kashyap at linaro.org>
> ---
>  arch/arm/lib/board.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index bcbf697..52e90db 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -281,10 +281,6 @@ void board_init_f (ulong bootflag)
>
>        gd->mon_len = _bss_end_ofs;
>
> -#ifdef CONFIG_MACH_TYPE
> -       gd->bd->bi_arch_number = CONFIG_MACH_TYPE; /* board id for Linux */
> -#endif
> -
>        for (init_fnc_ptr = init_sequence; *init_fnc_ptr; ++init_fnc_ptr) {
>                if ((*init_fnc_ptr)() != 0) {
>                        hang ();
> @@ -409,6 +405,10 @@ void board_init_f (ulong bootflag)
>        post_run (NULL, POST_ROM | post_bootmode_get(0));
>  #endif
>
> +#ifdef CONFIG_MACH_TYPE
> +       gd->bd->bi_arch_number = CONFIG_MACH_TYPE; /* board id for Linux */
> +#endif
> +
>        gd->bd->bi_baudrate = gd->baudrate;
>        /* Ram ist board specific, so move it to board code ... */
>        dram_init_banksize();
> --
> 1.7.3.4
>
>



-- 
with warm regards,
Chander Kashyap


More information about the U-Boot mailing list