[U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

[Kumar Gala]

On Jul 28, 2011, at 2:11 PM, Wolfgang Denk wrote:

> Dear York Sun,
> 
> In message <1311879751.29459.24.camel at oslab-l1> you wrote:
>> 
>> I don't agree one line with the module information corrupts the boot
>> messages. Do we have fixed format? Am I missing something?
> 
> Yes, we have a well defined format with clear indentation.  Just see
> my commit message for what I mean.
> 
>> I didn't count the time but don't think the one line message will add
>> much to boot time. And it does have real value even you don't use it.
> 
> No, it will not add much. But 100 characters at 115kbps is another 10
> milliseconds wasted for nothing.
> 
> It may have value to you, but for 99.X % of the users it is completey
> meaningless.

Its quite helpful for debug of customer issues.  Should we add a CONFIG_ option for this?

>>> Then feel free to add a custom command to display this specific
>>> information, but keep it off the regular, unconditionally printed boot
>>> messages.
>> 
>> That's another way to do it. But we don't have to add a new command if a
>> simple message does the job.
> 
> Guess you have to, as I will not accept adding too much verbosity in
> the boot messages. On contrary, I'm planning for some more patches to
> get rid of the uncontrolled rank growth that happened in the past.
> 
> Best regards,
> 
> Wolfgang Denk

- k