[U-Boot] [PATCH] post: fix up I/O helper usage

[Mike Frysinger]

On Thu, Jul 28, 2011 at 07:23, Wolfgang Denk wrote:
> Mike Frysinger wrote:
>> >> -     return in_le32((volatile void *)(_POST_WORD_ADDR));
>> >> +     return inl((volatile void *)(_POST_WORD_ADDR));
>> >>  }
>> >
>> > Is this supposed to fix any real problem, or just a change according
>> > to your personal preferences?
>>
>> the "in_le32" funcs (and all the other related "le32" helpers) never
>> made it into the common Linux API and many
>> ports (such as the Blackfin arch) never defined them.  so it fixes
>
> True.  But the same is also true for any other of the so-called
> "standard accessors".  The fact that some architectures are slow to
> adapt to the standards does not convince me that we have to always
> accept the lowest common denominator.  We can also push forward, at
> least sometimes.

sorry, but i dont think this qualifies.  ppc choosing to add some
arbitrary new macros by themselves which one or two other arches
happen to copy does not make them part of the influx standard.
looking at the linux/u-boot trees, ppc seems to be the only one that
implements it in both (and perhaps m68k).

> What we should be using (and standardizing for) is probably this (at
> least some of the PTBs said so in the past):
>
>         (*) ioreadX(), iowriteX()

that's fine by me

> Sorry, but I will not accept inl() here.

so not even to fix build failures for most non-ppc arches ?  i wont be
able to post an updated patch for a while.
-mike