[U-Boot] [PATCH 3/3] cfb_console.c: checkpatch cleanup

Sergei Shtylyov sshtylyov at mvista.com
Sat Jul 30 16:12:33 CEST 2011


Hello.

On 29-07-2011 23:55, Wolfgang Denk wrote:

> Fix the following:

> ERROR: do not initialise statics to 0 or NULL
> ERROR: do not use assignment in if condition

> Signed-off-by: Wolfgang Denk<wd at denx.de>
> ---
>   drivers/video/cfb_console.c |   16 ++++++++++------
>   1 files changed, 10 insertions(+), 6 deletions(-)

> diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
> index d2dd421..6e9143e 100644
> --- a/drivers/video/cfb_console.c
> +++ b/drivers/video/cfb_console.c
[...]
> @@ -1648,7 +1651,8 @@ static int video_init(void)
>   {
>   	unsigned char color8;
>
> -	if ((pGD = video_hw_init()) == NULL)
> +	pGD = video_hw_init()) == ;

    Did you try to compile this? :-)

WBR, Sergei


More information about the U-Boot mailing list