[U-Boot] [PATCH 5/5] scsi/ahci: add support for non-PCI controllers

Wolfgang Denk wd at denx.de
Wed Jun 1 21:31:06 CEST 2011


Dear Rob Herring,

In message <1306955427-18940-6-git-send-email-robherring2 at gmail.com> you wrote:
> From: Rob Herring <rob.herring at calxeda.com>
> 
> Add support for AHCI controllers that are not PCI based.


...
> +	memset((void *)ataid, 0, sizeof(hd_driveid_t *) * AHCI_MAX_PORTS);

This triggers a checkpatch error.

Why don;t you simply write:

	memset((void *)ataid, 0, sizeof(ataid)):

?

> +      err_out:

labels should not be indented


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
For every complex problem, there is a solution that is simple,  neat,
and wrong.                                               - Mark Twain


More information about the U-Boot mailing list