[U-Boot] [u-boot][PATCH] net/net.c: Update ipaddr if the environment has changed

Wolfgang Denk wd at denx.de
Wed Jun 1 22:18:10 CEST 2011


Dear Enric Balletbo i Serra,

In message <1306911707-10564-1-git-send-email-eballetbo at iseebcn.com> you wrote:
> At least on ARM the ipaddr is only set in board_init_r function. The
> problem is if ipaddr is not defined in environment importing another
> environment defined don't update the ipaddr value.
> 
> For example, suppose we've a default environment without net variables
> defined and we want to import an uEnv.txt environment from SD-card like
> this:
> 
>   ipaddr=192.168.2.240
>   netmask=255.255.255.0
>   gatewayip=192.168.2.1
>   serverip=192.168.2.114
> 
> Then if you try boot from NFS results in:
> 
>   Importing environment from mmc ...
>   Running uenvcmd ...
>   smc911x: detected LAN9221 controller
>   smc911x: phy initialized
>   smc911x: MAC ac:de:48:00:00:00
>   *** ERROR: `ipaddr' not set
> 
> The ipaddr at this point is NULL beacause is only set at board_init_r
> function. This patch updates the ipaddr value if the environment has
> changed.
> 
> Signed-off-by: Enric Balletbo i Serra <eballetbo at iseebcn.com>
> ---
>  net/net.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You said you  didn't  want  to  use  CGI.pm,  but  methinks  you  are
needlessly reinventing the wheel, one spoke at a time. Either you are
masochistic,  or  you  just haven't seen enough of what CGI.pm can do
for you. -- Randal L. Schwartz in <8cyb81rg81.fsf at gadget.cscaper.com>


More information about the U-Boot mailing list