[U-Boot] [PATCH v2] mx31ads: Use the new relocation scheme

[Fabio Estevam]

Hi Stefano,

On Thu, Jun 2, 2011 at 3:28 AM, Stefano Babic <sbabic at denx.de> wrote:
...
> I know it is the same, but if you use PHYS_SDRAM_1 instead of
> CONFIG_SYS_SDRAM_BASE (as most boards do), the reader understands easier
> that the start address and the size are strictly connected.

OK.

>
>> --- a/board/freescale/mx31ads/u-boot.lds +++
>> b/board/freescale/mx31ads/u-boot.lds @@ -48,23 +48,47 @@ SECTIONS
>>
>
> Can we get rid of this file ? We do not need anymore, and you can also
> remove config.mk as well.

If I remove the board/freescale/mx31ads/u-boot.ld then I get the
following error:

010q1/bin/../lib/gcc/arm-none-linux-gnueabi/4.4.1/armv4t -lgcc -Map
u-boot.map -o u-boot
common/libcommon.o:(.data+0x80c): undefined reference to `environment'

and I think that is due to the fact that
board/freescale/mx31ads/u-boot.ld is a bit customized as per the
comment below:

.text	   :
	{
	  /* WARNING - the following is hand-optimized to fit within	*/
	  /* the sector layout of our flash chips!	XXX FIXME XXX	*/

	  arch/arm/cpu/arm1136/start.o			(.text)
	  board/freescale/mx31ads/libmx31ads.o	(.text)
	  arch/arm/lib/libarm.o			(.text)
	  net/libnet.o				(.text)
	  drivers/mtd/libmtd.o			(.text)

	  . = DEFINED(env_offset) ? env_offset : .;
	  common/env_embedded.o(.text)

My intention on this patch was to fix the MX31ADS build so that this
board does not get removed from U-boot.

Would it be OK if I resend a new patch taking in consideration your
other comments, except the removal of
board/freescale/mx31ads/u-boot.ld ?

Or would you have any other suggestion?

Regards,

Fabio Estevam