[U-Boot] [PATCH 2/4] build/mkconfig: Add EXTRA_OPTS argument to make to modify build

Mike Frysinger vapier at gentoo.org
Fri Jun 3 06:56:13 CEST 2011


On Thursday, June 02, 2011 15:34:58 Matthew McClintock wrote:
> --- a/mkconfig
> +++ b/mkconfig
> @@ -81,6 +81,12 @@ if [ "${ARCH}" -a "${ARCH}" != "${arch}" ]; then
>  	exit 1
>  fi
> 
> +if [ -z "${options}" ] ; then
> +options+=$EXTRA_OPTS
> +else
> +options+=,$EXTRA_OPTS
> +fi

style is broken (lacking indentation), and the "+=" operator is not in the 
POSIX shell spec
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110603/60a6fbc1/attachment.pgp 


More information about the U-Boot mailing list