[U-Boot] [PATCH v2 2/4] build/mkconfig: Add EXTRA_OPTS argument to make to modify build

[Mike Frysinger]

On Friday, June 03, 2011 14:36:03 Matthew McClintock wrote:
> +if [ -z "${options}" ] ; then
> +	options=$EXTRA_OPTS
> +else
> +	options="$options,$EXTRA_OPTS"
> +fi

this can be simplified (or at least done in one line) with:
options=${options:+${options},}${EXTRA_OPTS}

although i can understand that not everyone can grok that at first blush

> +TARGETS+=`echo $EXTRA_OPTS | tr ',' ' '`

you're still using non-portable += append operator

although i dont understand how EXTRA_OPTS can both be extra options and extra 
targets at the same time ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110603/e031d19d/attachment.pgp