[U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch

Reinhard Meyer u-boot at emk-elektronik.de
Sun Jun 5 14:57:48 CEST 2011


Dear Simon Glass,
> Hi Reinhard,
> 
> I have been asked to have a quick look at this patch, which is showing accepted here:
> 
> http://patchwork.ozlabs.org/patch/81422/
> 
> The diffstat on patchwork is:
> 
>  MAINTAINERS                               |    5 +
>  board/bluewater/snapper9260/Makefile      |   53 ++++++++
>  board/bluewater/snapper9260/snapper9260.c |  169 +++++++++++++++++++++++++
>  boards.cfg                                |    2 +
>  include/configs/snapper9260.h             |  191 +++++++++++++++++++++++++++++
>  5 files changed, 420 insertions(+), 0 deletions(-)
>  create mode 100644 board/bluewater/snapper9260/Makefile
>  create mode 100644 board/bluewater/snapper9260/snapper9260.c
>  create mode 100644 include/configs/snapper9260.h
> 
> but when I look at the commit I only see this:
> 
> git log --author=Ryan --stat
> commit 74cd9777f8dd44fd944a9ac75cfbc24eeb206453
> Author: Ryan Mallon <ryan at bluewatersys.com <mailto:ryan at bluewatersys.com>>
> Date:   Tue Feb 1 16:18:00 2011 +0000
> 
>     Add support for Bluewater Systems Snapper 9260 and 9G20 modules
>     
>     Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
>     single board computer modules. Includes NAND flash and Ethernet
>     support.
>     
>     Signed-off-by: Ryan Mallon <ryan at bluewatersys.com <mailto:ryan at bluewatersys.com>>
> 
>  boards.cfg |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> 
> As a result it does not build. Has something been dropped by mistake?

I had accepted that patch after manually fixing the style problems. I do not know why the
fixed files got lost. The accepted patch was V3. Since then a V4 patch had been posted to
which Albert had commented and I therefore put it on "changes requested".
I would think its now the best way to get a redone V5 patch (based on current TOT)
for those boards ASAP.
Sorry for the mixup.

Best Regards,
Reinhard


More information about the U-Boot mailing list