[U-Boot] [PATCH] net: designware: fix uninitialized phy_addr usage

Vipin Kumar vipin.kumar at st.com
Mon Jun 6 06:21:42 CEST 2011


On 6/2/2011 8:49 PM, Mike Frysinger wrote:
> When CONFIG_DW_SEARCH_PHY is disabled, the local phy_addr variable never
> gets initialized causes random behavior at runtime and a gcc warning.  So
> set it by default to the stored phy address.
> 
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> ---
>  drivers/net/designware.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/designware.c b/drivers/net/designware.c
> index 96f20d1..bfa4384 100644
> --- a/drivers/net/designware.c
> +++ b/drivers/net/designware.c
> @@ -383,6 +383,8 @@ static int configure_phy(struct eth_device *dev)
>  		priv->address = phy_addr;
>  	else
>  		return -1;
> +#else
> +	phy_addr = priv->address;
>  #endif
>  	if (dw_reset_phy(dev) < 0)
>  		return -1;

Reviewed-by: Vipin Kumar <vipin.kumar at st.com>
Thanks Mike

Regards
Vipin


More information about the U-Boot mailing list