[U-Boot] [PATCH] powerpc/85xx: Add basic support for P1023RDS board

Wolfgang Denk wd at denx.de
Wed Jun 8 07:30:39 CEST 2011


Dear Roy Zang,

In message <1307508687-12522-1-git-send-email-tie-fei.zang at freescale.com> you wrote:
> The P1023RDS board is the reference board for the P1023 SoC.
> 
> Add support for booting it from NOR or NAND, with fixed 2G of DDR, PCIe,
> UART, I2C, etc.

Please fix the checkpatch warnings (7 lines over 80 characters)

...
> +/* ECC will be enabled based on perf_mode environment variable */
> +#undef	CONFIG_DDR_ECC
...
> +#undef CONFIG_CLOCKS_IN_MHZ
...
> +#undef CONFIG_SYS_RAMBOOT
...
> +#undef	CONFIG_SERIAL_SOFTWARE_FIFO
...
> +#undef	CONFIG_SOFT_I2C		/* I2C bit-banged */
...
> +#undef CONFIG_WATCHDOG			/* watchdog disabled */
...
> +#undef  CONFIG_BOOTARGS		/* the boot command will set bootargs */

etc.  Please do not undef what is not defined in the first place.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real Programmers always confuse Christmas and Halloween because
OCT 31 == DEC 25 !  - Andrew Rutherford (andrewr at ucs.adelaide.edu.au)


More information about the U-Boot mailing list