[U-Boot] [PATCH v2 4/5] arm/km: replace suenx targets with km_kirkwood

[Longchamp, Valentin]

Hi Prafulla,

Sorry for the bad email formatting, using webmail from home. See my answer below.


-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Sat 6/11/2011 6:50 AM
To: Brunck, Holger; u-boot at lists.denx.de
Cc: Longchamp, Valentin; Heiko Schocher
Subject: RE: [PATCH v2 4/5] arm/km: replace suenx targets with km_kirkwood
 


> -----Original Message-----
> From: Prafulla Wadaskar
> Sent: Saturday, June 11, 2011 9:53 AM
> To: 'Holger Brunck'; u-boot at lists.denx.de
> Cc: Valentin Longchamp; Heiko Schocher
> Subject: RE: [PATCH v2 4/5] arm/km: replace suenx targets with
> km_kirkwood
> 
> 
> 
> > -----Original Message-----
> > From: Holger Brunck [mailto:holger.brunck at keymile.com]
> > Sent: Wednesday, June 08, 2011 5:13 PM
> > To: u-boot at lists.denx.de
> > Cc: Holger Brunck; Valentin Longchamp; Prafulla Wadaskar; Heiko
> Schocher
> > Subject: [PATCH v2 4/5] arm/km: replace suenx targets with km_kirkwood
> >
> > suen3 and suen8 were in first HW version quite different, but
> > now they are from a u-boot point of view similar. So these
> > two boards can use the same header file. Other keymile boards
> > differ only in the usage of the PCI interface. Therefore
> > a target km_kirkwood_pci was introduced. All targets use
> > the same header file.
> >
> > Signed-off-by: Holger Brunck <holger.brunck at keymile.com>
> > Signed-off-by: Valentin Longchamp <valentin.longchamp at keymile.com>
> > cc: Prafulla Wadaskar <prafulla at marvell.com>
> > cc: Heiko Schocher <hs at denx.de>
> > ---
> > Changes for v2:
> >     - squashed together with 5/6 from previous serie, because
> >       the pci defines belongs logically to this patch
> >     - change typo in board maintainers name
> >
> >  MAINTAINERS                                |    6 ++-
> >  MAKEALL                                    |    2 +-
> >  boards.cfg                                 |    4 +-
> >  include/configs/km/km_arm.h                |    1 -
> >  include/configs/{suen3.h => km_kirkwood.h} |   18 +++++++---
> >  include/configs/mgcoge3un.h                |    5 +++
> >  include/configs/suen8.h                    |   50 -------------------
> --
> > -------
> 
> Applied to u-boot-marvell.git next branch
> Regards..
> Prafulla . .

Hi Holger, Valentin

During this pull check I observed that u-boot.kwb image generation gives build errors for all Kirkwood based keymile boards.

Please kindly check on this and provide a fix.

I had noticed about this u-boot.kwb image generation earlier, but we don't use it internally yet. We would like to change this and use it (and thus fix this error).

Could you please answer my early question from this thread: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/99206

Here is my question again:

Now I have a question about the marvell boards build: I see in the 
Makefile that there is a rule about this kwb file, which is exactly what 
we do in our additionnal build script:

$(obj)u-boot.kwb:       $(obj)u-boot.bin
		$(obj)tools/mkimage -n $(CONFIG_SYS_KWD_CONFIG) -T kwbimage \
		-a $(CONFIG_SYS_TEXT_BASE) -e $(CONFIG_SYS_TEXT_BASE) -d $< $

How do you use it (because I think it is not called by the default make 
command) ?

Best Regards

Valentin