[U-Boot] [PATCH] mx31: Improve the handling of unidentified silicon version

Wolfgang Denk wd at denx.de
Wed Jun 15 07:28:56 CEST 2011


Dear Fabio Estevam,

In message <1308069108-5438-1-git-send-email-fabio.estevam at freescale.com> you wrote:
...
> However it is possible to find some pre-production silicon on some old hardware, such as MX31ADS
> that shows srev = 0x20.
> 
> The following message is the currently displayed on such MX31ADS board:
> 
> CPU:   Freescale i.MX31 rev 2.0 unknown at 531 MHz.Reset cause: WDOG
> 
> With this patch we see a better message like:
> 
> CPU:   Freescale i.MX31 rev 0.0 (unknown revision) at 531 MHz.Reset cause: WDOG

The old information is way more useful, and shorter, than the new one.
And the code is smaller and without any magic, too.


I agree with Graeme: we should rather leave the code as is.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Unix is simple, but it takes a genius to understand the simplicity."
					             - Dennis Ritchie


More information about the U-Boot mailing list