[U-Boot] [PATCH] mx31: Improve the handling of unidentified silicon version

Wolfgang Denk wd at denx.de
Wed Jun 15 14:47:16 CEST 2011


Dear Stefano Babic,

In message <4DF8A2DE.3040501 at denx.de> you wrote:
>
> > Reading rev 2.0 on Felix=B4s case is misleading IMHO as we tend to
> > think that we have a TO2.0 silicon on his board even though we get a
> > "unknown" string.
> 
> Ok, so only reading the code we can know that version number + "unknown"
> give us the value of the srev register. We can explicitely expand the
> output to make things clearer.

Given that this is an exotic error case that happens only on a very
small number of chips that are actually not supposed to exist at all,
I think this is not worth the effort.

The "unknown" is warning enough, and anybody who needs to know more
details can see theremaining details easily from the code.

> Agree with your proposal.

No.  We should not add code that is almost never ever useful anywhere,
just to make this message more verbose.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Was heißt Windows auf Indianisch? - "Weißer  Mann,  der  auf  Sanduhr
wartet!"


More information about the U-Boot mailing list