[U-Boot] SPL framework re-design

Scott Wood scottwood at freescale.com
Sat Jun 18 00:28:27 CEST 2011


On Fri, 17 Jun 2011 22:18:57 +0530
Aneesh V <aneesh at ti.com> wrote:

> @@ -1158,6 +1164,7 @@ clobber:	clean
>   	@[ ! -d $(obj)nand_spl ] || find $(obj)nand_spl -name "*" -type l 
> -print | xargs rm -f
>   	@[ ! -d $(obj)onenand_ipl ] || find $(obj)onenand_ipl -name "*" -type 
> l -print | xargs rm -f
>   	@[ ! -d $(obj)mmc_spl ] || find $(obj)mmc_spl -name "*" -type l 
> -print | xargs rm -f
> +	@[ ! -d $(obj)spl ] || find $(obj)mmc_spl -name "*" -type l -print | 
> xargs rm -f

That last mmc_spl should just be spl.

> +LIBS-$(CONFIG_SYS_SPL_NAND_SUPPORT) += mmc/libnand.o
> +LIBS-$(CONFIG_SYS_SPL_ONENAND_SUPPORT) += mmc/libonenand.o

Why are these in mmc?

What is it you propose would be in these files?

> +$(LIBS-y):	depend
> +		$(MAKE) -C $(dir $(subst $(obj),,$@)) all

If no libraries are selected, this will produce a rule with an empty
target, which is undefined behavior.

-Scott



More information about the U-Boot mailing list