[U-Boot] [U-Boot PATCH MX31:] smc911x MII made available

[Helmut Raiger]

On 06/20/2011 02:30 PM, Stefano Babic wrote:
>
> Not noted before, thanks for fixing it. Only to remark the issue, on
> boards with SMC911x (at least the one I tested your patch) and
> CONFIG_CMD_MII set, a simple "mii info" returns "Read MDIO failed.."
>
Our board holds a SMSC LAN9211-ABZJ , 'mii info' returns:

PHY 0x00: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x01: OUI = 0x01F0, Model = 0x0C, Rev = 0x03, 100baseT, FDX
PHY 0x02: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x03: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x04: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x05: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x06: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x07: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x08: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x09: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x0A: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x0B: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x0C: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x0D: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x0E: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x0F: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x10: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x11: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x12: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x13: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x14: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x15: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x16: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x17: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x18: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x19: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x1A: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x1B: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x1C: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x1D: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x1E: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX
PHY 0x1F: OUI = 0x0000, Model = 0x00, Rev = 0x00,  10baseT, HDX

'mii device' says:

MII devices: 'smc911x-0'
Current device: 'smc911x-0'
> You should always put in CC the maintainer for your patches. Because
> this patch is related to network, you should send your changes to
> Wolfgang Denk (Network Maintaner), too. I have already set his name in CC.
>
Ok, I did search the MAINTAINER file, but could not attach a name to my 
fix, neither smc... nor network, nor something else.
>> +#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
>> +/* wrapper for smc911x_miiphy_read */
>> +static int _phy_read(char *devname, u8 phy, u8 reg, u16 *val)
> Is there some reason to use name starting with _ ? They have special
> meaning, and there is no need here.
>
No, I wasn't aware of the _ meaning. I usually name wrappers that way, 
but only personal preference. I'll fix the naming along with other 
things that might come up.

> I have tested your patch on the mx35pdk board.
>
> Tested-by: Stefano Babic<sbabic at denx.de>
>
> Best regards,
> Stefano Babic
>
Thanks for testing,
Helmut



--
Scanned by MailScanner.