[U-Boot] [PATCH V2 1/2] MMC: unify mmc read and write operation

Mike Frysinger vapier at gentoo.org
Wed Jun 22 18:54:09 CEST 2011


On Monday, June 20, 2011 10:10:15 Lei Wen wrote:
> +	enum mmc_state state;
> +	if (strcmp(argv[1], "read") == 0)
> +		state = MMC_READ;
> +	else if (strcmp(argv[1], "write") == 0)
> +		state = MMC_WRITE;
> +	else
> +		state = MMC_INVALID;

i think wolfgang hates inline var decls (c99), so that "state" will have to be 
moved up.  also, there should be a newline after this if block.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110622/6acdf2ff/attachment.pgp 


More information about the U-Boot mailing list