[U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use

Wolfgang Denk wd at denx.de
Fri Jun 24 07:18:55 CEST 2011


Dear "Jason Hobbs",

In message <1308853655-12407-4-git-send-email-jason.hobbs at calxeda.com> you wrote:
> Signed-off-by: Jason Hobbs <jason.hobbs at calxeda.com>
> ---
> changes in v2:
> - expose abortboot externally instead of using a wrapper
> - expose abortboot externally when CONFIG_MENU is set
> 
>  common/main.c    |   12 ++++++++----
>  include/common.h |    3 +++
>  2 files changed, 11 insertions(+), 4 deletions(-)
...
> +#ifdef CONFIG_MENU

This being a new CONFIG_ variable, it must be documented in the
README.  But as is this makes little sense, so I suggest you change
the order of your patches and add the abortboot support to the menu
system in a second step, after adding (and documenting) the menu
stuff.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You have the capacity to learn from  mistakes.  You'll  learn  a  lot
today.


More information about the U-Boot mailing list