[U-Boot] Removal of generated asm-offsets.s/h

[Stefano Babic]

On 06/29/2011 05:00 PM, Matthias Weißer wrote:
> Am 29.06.2011 16:20, schrieb Wolfgang Denk:
>> Dear =?ISO-8859-15?Q?Matthias_Wei=DFer?=,
>>

Hi Matthias,

>> In message<4E0B3331.9030605 at arcor.de>  you wrote:
>>>
>>> If a soc automatically generates asm-offsets.s/h in its makefile it
>>> isn't removed by a make clean or make distclean. See mx35 as an example.
>>> Even adding a clean: target to the SoCs makefile doesn't help. What
>>> would be the right way to remove these files with make clean?
>>
>> Add it to the list of files to remove in the top level Makefile?
> 
> Well, thats is not that easy. The generated asm-offsets.h file ends up 
> in arch/arm/include/asm/arch-mx35/ after a "make mx35pdk_config" "make" 
> "make distclean" run. It is generated to include/asm/arch/ in the SoCs 
> makefile so I don't understand why it ends up in 
> arch/arm/include/asm/arch-mx35/

There is an explicit rule in arch/arm/cpu/arm1136/mx35/Makefile. It
seems to me the right place to put the generated file. It is an include
header, and it should be the include directory for the desired soc, in
this case arch/arm/include/asm/arch-mx35/

> 
> I don't think it makes sense to add a entry for each SoC using auto 
> generated asm-offset files to the top level makefile. Same goes for the 
> .s file as we shouldn't remove all .s files in the tree.

Is it not enough to add the following lines to the central Makefile, as
suggested by Wolfgang:

       @rm -f arch/$(ARCH)/include/asm/arch-$(SOC)/asm-offsets.h
       @rm -f $(CPUDIR)/$(SOC)/asm-offsets.s

The files are removed, as I now tested.
And we do not need to add an entry for each CPU/SOC...

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================