[U-Boot] [PATCH 21/21] Remove legacy do_reset() function

[Graeme Russ]

On Tue, Mar 8, 2011 at 10:00 AM, Moffett, Kyle D
<Kyle.D.Moffett at boeing.com> wrote:
> Hi!
>
> On Mar 07, 2011, at 16:55, Graeme Russ wrote:
>> On Tue, Mar 8, 2011 at 4:37 AM, Kyle Moffett <Kyle.D.Moffett at boeing.com> wrote:
>>> All of the users of the legacy do_reset() function have been converted
>>> to __arch_restart() or __board_restart() as appropriate, so the
>>> compatibility calls to do_reset() may be removed.
>>>
>>> In addition the do_generic_reset() function is renamed to the now-unused
>>> name do_reset().
>>
>> If it is unused, why not remove it completely?
>
> The "reset" command used to invoke "do_reset()".  Partway through this patch series I changed it to invoke a new "do_generic_reset()" function to preserve bisection.
>
> The calltrace looked like this:
>
> => do_generic_reset()
>   => system_restart()
>      => __board_restart()
>      => __arch_restart()
>      => do_reset()
>
> Now that nothing talks about "do_reset()" anymore, I delete that old function and rename "do_generic_reset()" over top of it:
>
> => do_reset()  [Same as old do_generic_reset()]
>   => system_restart()
>      => __board_restart()
>      => __arch_restart()
>
> Cheers,
> Kyle Moffett

Go it - Thanks

Regards,

Graeme