[U-Boot] [PATCH 0/21] Generic cross-architecture system restart support

Wolfgang Denk wd at denx.de
Sun Mar 13 20:16:51 CET 2011


Dear Kyle Moffett,

In message <1299519462-25320-1-git-send-email-Kyle.D.Moffett at boeing.com> you wrote:
> 
> This patchset is designed to produce zero change in behavior *except* for
> one particular scenario:  Platforms which perform a "restart" with a simple
> jump to the "_start" entrypoint (or similar) will no longer try to do that
> on panic().
> 
> The new functions to be called from generic code are:
> 
>   int system_restart(void)
>   void emergency_restart(void)

Could you please explain what these functions are supposed to do?

> The first few patches set up the generic functions and hooks with a default
> fallback to the existing "do_reset()" function.  Most of the rest are then
> architecture-specific modifications necessary to convert away from the old
> do_reset() prototype.  The last patch finally does away with that function.

Why do you replace a simple name like "reset" with a more complicated
name like "system_restart"?

What is emergency_restart() needed for?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I wish I had a bronze torc for every user who didn't read the manual.
                             - Terry Pratchett, _The Light Fantastic_


More information about the U-Boot mailing list