[U-Boot] [PATCH 1/2] sh: Add handling of CONFIG_SYS_FLASH_BASE for board.c

Wolfgang Denk wd at denx.de
Sun Mar 13 22:45:38 CET 2011


Dear Nobuhiro Iwamatsu,

In message <1299484258-6042-1-git-send-email-nobuhiro.iwamatsu.yj at renesas.com> you wrote:
> Some board of SH does not have flash memoy.
> This change initializes bi_flashstart, when CONFIG_SYS_FLASH_BASE was defined,
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>
> ---
>  arch/sh/lib/board.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/sh/lib/board.c b/arch/sh/lib/board.c
> index 968566c..81244ae 100644
> --- a/arch/sh/lib/board.c
> +++ b/arch/sh/lib/board.c
> @@ -43,6 +43,7 @@ const char version_string[] = U_BOOT_VERSION" ("U_BOOT_DATE" - "U_BOOT_TIME")";
>  
>  unsigned long monitor_flash_len = CONFIG_SYS_MONITOR_LEN;
>  
> +#if defined(CONFIG_SYS_FLASH_BASE)

I don't think this should depend on CONFIG_SYS_FLASH_BASE.

Boards without NOR flash should define CONFIG_SYS_NO_FLASH, and this
define should be used here.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An armed society is a polite society.


More information about the U-Boot mailing list