[U-Boot] [PATCH 01/20] keymile: rework headerfiles for keymile boards

[Heiko Schocher]

Hello Wolfgang,

Wolfgang Denk wrote:
> In message <1299591018-8944-2-git-send-email-hs at denx.de> you wrote:
>> - This patch reworks all headerfiles for keymile boards (coge, supx4,
>>   eter1, suen3).
>>   Furthermore, a refactoring on the whole environment variables has been
>>   acomplished.
> 
> Two independent changes => Please submit as two separate patches.

Ok, I try to split this in two patches.

> ...
>> +#define CONFIG_HUSH_INIT_VAR		1
> ...
>> +#define CONFIG_I2C_MULTI_BUS		1
> ...
>> +#define CONFIG_I2C_MUX			1
> 
> Defines like these that select functions only should not be assigned
> any numeric (or other value).  Please omit thse.  Please fix globally.

Ok.

>> +#define CONFIG_KM_DEF_ENV_CONSTANTS					\
> ...
>> +	"default="							\
>> +		"setenv default \'run newenv; reset\' &&  "		\
> 
> These backslashes are redundant at best.  Why not drop them?

Ok, drop it.

> ...
>> +	"u-boot=" xstr(CONFIG_HOSTNAME) "/u-boot.bin \0" 		\
> 
> Are you sure you really want that trailing blank? [Please check
> globally.]

Good cathc, check this.

> ...
>> +#define CONFIG_SYS_MONITOR_LEN		(768 << 10)	/* Reserve 768KB for Monitor */
> 
> Line too long.  Please fix globally.

Ok.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany