[U-Boot] [PATCH 02/20] mpc832x: add support for the mpc8321 based suvd3 board

[Wolfgang Denk]

Dear Heiko,

In message <4D7DC1C1.4060209 at denx.de> you wrote:
> 
> >> +	im->sysconf.ddrlaw[0].bar = CONFIG_SYS_DDR_BASE & LAWBAR_BAR;
> >> +	msize = fixed_sdram ();
> > 
> > Can we not use get_ram_size() ?
> 
> fixed_sdram calls this.

I see, thanks.

> > I see this:
> > 
> > [PATCH 01/20] keymile: rework headerfiles for keymile boards
> > total: 0 errors, 16 warnings, 659 lines checked
> 
> Hmm... I see other statistics:

I'm using

	-> checkpatch.pl --version
	Usage: checkpatch.pl [OPTION]... [FILE]...
	Version: 0.31

> [hs at pollux u-boot]$ ./../linux-2.6-denx/scripts/checkpatch.pl 20110308/0001-keymile-rework-headerfiles-for-keymile-boards.patch

This should be the same version, assuming your repository is up to
date.

> WARNING: line over 80 characters
> #636: FILE: include/configs/kmeter1.h:179:
> +#define CONFIG_SYS_MONITOR_LEN         (768 * 1024) /* Reserve 768 kB for Mon */
> 
> WARNING: line over 80 characters
> #750: FILE: include/configs/mgcoge.h:133:
> +#define CONFIG_SYS_MONITOR_LEN         (768 << 10)     /* Reserve 768KB for Monitor */
> 
> total: 0 errors, 2 warnings, 659 lines checked
> 
> 20110313/0001-keymile-rework-headerfiles-for-keymile-boards.patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> [hs at pollux u-boot]$
> 
> Only 2 warnings ... which checkpatch.pl do you use?

You must be doing something wrong.

On pollux, as you:

-> /home/git/linux-2.6-denx/scripts/checkpatch.pl --no-tree /tmp/patch
WARNING: please, no space before tabs
#221: FILE: include/configs/keymile-common.h:117:
+#define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS ^I3$

...
WARNING: please, no space before tabs
#791: FILE: include/configs/mgcoge.h:107:
+^I^I"era 0xFE0C0000 +0x40000\0" ^I^I^I^I\$

WARNING: line over 80 characters
#801: FILE: include/configs/mgcoge.h:133:
+#define CONFIG_SYS_MONITOR_LEN         (768 << 10)     /* Reserve 768KB for Monitor */

total: 0 errors, 16 warnings, 659 lines checked



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'm a soldier, not a diplomat.  I can only tell the truth.
	-- Kirk, "Errand of Mercy", stardate 3198.9