[U-Boot] [PATCH 1/8] pxa: move i2c driver to the common place

Lei Wen adrian.wenl at gmail.com
Tue Mar 15 02:36:48 CET 2011


Hi Prafulla,

On Mon, Mar 14, 2011 at 8:03 PM, Prafulla Wadaskar <prafulla at marvell.com> wrote:
>
>
>> -----Original Message-----
>> From: Lei Wen [mailto:leiwen at marvell.com]
>> Sent: Monday, March 14, 2011 3:46 PM
>> To: u-boot at lists.denx.de; Marek Vasut; Prafulla Wadaskar; Lei Wen
>> Subject: [PATCH 1/8] pxa: move i2c driver to the common place
>>
>> For better sharing with other platform other than pxa's,
>> it is more convenient to put the driver to the common place.
>>
>> Signed-off-by: Lei Wen <leiwen at marvell.com>
>> ---
>>  arch/arm/cpu/pxa/Makefile |    1 -
>>  arch/arm/cpu/pxa/i2c.c    |  469 --------------------------------------
>> -------
>>  drivers/i2c/Makefile      |    1 +
>>  drivers/i2c/pxa_i2c.c     |  469
>> +++++++++++++++++++++++++++++++++++++++++++++
>
> Hi Lei
> It looks like this is cut-paste, have you done git-mv? Pls confirm
Good catch. :) I would use the git-mv to redo the patch.

>
> Secondly
> Since this will be supported by multiple Marvell SoC cores.
> How about renaming new moved i2c driver as mvi2c.c?

Yep, I'm ok with this change. I would post modified patch later.

Thanks,
Lei


More information about the U-Boot mailing list