[U-Boot] [PATCH 1/3] ARM: Don't grab memory for LCD if FB address is defined

Minkyu Kang promsoft at gmail.com
Tue Mar 15 03:16:20 CET 2011


Dear Wolfgang,

On 14 March 2011 04:50, Wolfgang Denk <wd at denx.de> wrote:
> Dear Minkyu Kang,
>
> In message <4D75B591.3040605 at samsung.com> you wrote:
>> If FB address is defined specific address then don't grab memory for LCD
>>
>> Signed-off-by: Minkyu Kang <mk7.kang at samsung.com>
>> Cc: Albert Aribaud <albert.aribaud at free.fr>
>> ---
>>  arch/arm/lib/board.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
>> index c620d2c..5a4d2bd 100644
>> --- a/arch/arm/lib/board.c
>> +++ b/arch/arm/lib/board.c
>> @@ -356,9 +356,13 @@ void board_init_f (ulong bootflag)
>>  #endif /* CONFIG_VFD */
>>
>>  #ifdef CONFIG_LCD
>> +#ifdef CONFIG_FB_ADDR
>
> If you add a new CONFIG_ option, then you must document it (at least
> in the README).
>
>
> Also, you must not split this into several patches, one for each
> architecture.  All these changes must be done in a single commit.
>

OK, I will.

Thanks
Minkyu Kang
-- 
from. prom.
www.promsoft.net


More information about the U-Boot mailing list