[U-Boot] [PATCH V2 1/5] pxa: move i2c driver to the common place
Wolfgang Denk
wd at denx.de
Tue Mar 15 09:09:15 CET 2011
Dear Lei Wen,
In message <1300160443-12552-2-git-send-email-leiwen at marvell.com> you wrote:
> For better sharing with other platform other than pxa's,
> it is more convenient to put the driver to the common place.
>
> Signed-off-by: Lei Wen <leiwen at marvell.com>
> ---
> Changelog:
> v2: rename previous pxa_i2c to mvi2c.
>
> arch/arm/cpu/pxa/Makefile | 1 -
> arch/arm/cpu/pxa/i2c.c | 469 ---------------------------------------------
> drivers/i2c/Makefile | 1 +
> drivers/i2c/mvi2c.c | 469 +++++++++++++++++++++++++++++++++++++++++++++
I object against the name "mvi2c" - it's impossible to understand what
this is supposed to mean. Please make this mv_i2c or marvell_i2c or
similar, so we can see that "mv" or "marvell" is just a prefix.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Testing can show the presense of bugs, but not their absence.
-- Edsger Dijkstra
More information about the U-Boot
mailing list