[U-Boot] [PATCH AT91] Add watchdog reset to the at91samx SOC family
Michael Trimarchi
trimarchi at gandalf.sssup.it
Tue Mar 15 13:09:47 CET 2011
HI
On 03/15/2011 01:01 PM, Reinhard Meyer wrote:
> Dear Michael Trimarchi,
>> This patch add the watchdog reset function to the atmel atsam9x architectures.
>
> NAK.
>
> Watchdog already exists at drivers/watchdog/at91sam9_wdt.c :)
>
> Maybe its a bit of an obscure location... But it is already invented ;)
>
>> + int re_enable = disable_interrupts();
>> +
>> + writel(AT91_WDT_CR_WDRSTT | AT91_WDT_CR_KEY, &wdt->cr);
>> +
>> + if (re_enable)
>> + enable_interrupts();
>
Yes was obscured, and it is the only one :) there
Michael
> Besides... why would we need to disable IRQs here, writel() is using one instruction
> to write to the address?
>
> Best Regards,
>
> Reinhard
>
More information about the U-Boot
mailing list