[U-Boot] [PATCH v6 3/4] mpc85xx: Add a board-specific restart hook

[Wolfgang Denk]

Dear Kyle Moffett,

In message <1300208664-18339-4-git-send-email-Kyle.D.Moffett at boeing.com> you wrote:
> The HWW-1U-1A board needs to be able to override the "reset" command due
> to hardware design limitations.
> 
> Signed-off-by: Kyle Moffett <Kyle.D.Moffett at boeing.com>
> Cc: Andy Fleming <afleming at gmail.com>
> Cc: Kumar Gala <kumar.gala at freescale.com>

Please run checkpatch on your submissions!

>  #if defined(CONFIG_MPC8540) || defined(CONFIG_MPC8541) || \
>      defined(CONFIG_MPC8555) || defined(CONFIG_MPC8560)
> +int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
>  	unsigned long val, msr;

WARNING: space prohibited between function name and open parenthesis '('
#114: FILE: arch/powerpc/cpu/mpc85xx/cpu.c:215:
+int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

> -	volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
> +int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{

WARNING: space prohibited between function name and open parenthesis '('
#126: FILE: arch/powerpc/cpu/mpc85xx/cpu.c:232:
+int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

> +#endif
> +
> +

Please don't add trailing empty lines.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Humanity has the  stars  in  its  future,  and  that  future  is  too
important  to be lost under the burden of juvenile folly and ignorant
superstition.                                          - Isaac Asimov