[U-Boot] [PATCH v2 1/2] power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday

[Po-Yu Chuang]

Hi Macpaul,

On Fri, Mar 18, 2011 at 1:57 PM, Macpaul Lin <macpaul at gmail.com> wrote:
> 2011/2/18 Po-Yu Chuang <ratbert.chuang at gmail.com>
>> move include/ftpmu010.h to include/faraday/ftpmu010.h
>>
>>  drivers/power/ftpmu010.c   |    2 +-
>>  drivers/power/ftpmu010.h   |  146 ------------------------------------------
>>  include/faraday/ftpmu010.h |  150 ++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 151 insertions(+), 147 deletions(-)
>>  delete mode 100644 drivers/power/ftpmu010.h
>>  create mode 100644 include/faraday/ftpmu010.h
>
> Sorry I didn't notice that there are API declaration before in ftpmu010.h.
>
>> +void ftpmu010_32768osc_enable(void);

This is used by a320evb.

>> +void ftpmu010_dlldis_disable(void);
>> +void ftpmu010_sdram_clk_disable(unsigned int cr0);

These are not.

> Po-Yu, does these three function declaration is a necessity in a320evb?
>
> I'm using gcc 4.4 without these 3 function declaration seems okay.

Either adp-ag101 does not use any of them or you put the declarations
somewhere in board-specific code which is wrong.

> Because I'm going to refine another enhancement patch for using
> ftpmu010 in lowlevel_init.S.
> Hence I need to use #ifndef __ASSEMBLY__ to protect these three APIs.

No problem here. Please use __ASSEMBLY__.

> However, to compile adp-ag101 board (NDS32) doesn't require
> these 3 functions to be declared here. I need your opinion to clarify this.

Does your board use ftpmu010_dlldis_disable() or
ftpmu010_sdram_clk_disable() ?

Best regards,
Po-Yu Chuang