[U-Boot] [PATCH] DA8xx: fix LPSC numbering

[Wolfgang Denk]

Dear Laurence Withers,

In message <20110321203839.GA15999 at lwithers.me.uk> you wrote:
>
> > Please fix also all other places where these identifiers are used in
> > the code.
> 
> The identifiers changed in the patch were not used anywhere in the code. I
> also verified that a "./MAKEALL -s davinci" gave the same results before
> and after.

I cannot confirm this; for example, you change:

-	DAVINCI_LPSC_TPCC = 0,
+	DAVINCI_LPSC_TPCC0 = 0,

I see:

-> grep -R DAVINCI_LPSC_TPCC *
arch/arm/include/asm/arch-davinci/hardware.h:#define DAVINCI_LPSC_TPCC          2
arch/arm/include/asm/arch-davinci/hardware.h:   DAVINCI_LPSC_TPCC = 0,
board/davinci/dm355evm/dm355evm.c:      lpsc_on(DAVINCI_LPSC_TPCC);

you change:

-	DAVINCI_LPSC_MMC_SD,
+	DAVINCI_LPSC_MMC_SD0,

I see:

-> grep -R DAVINCI_LPSC_MMC_SD *
arch/arm/cpu/arm926ejs/davinci/psc.c:   case DAVINCI_LPSC_MMC_SD:
arch/arm/include/asm/arch-davinci/hardware.h:#define DAVINCI_LPSC_MMC_SD                15
arch/arm/include/asm/arch-davinci/hardware.h:   DAVINCI_LPSC_MMC_SD,


Seems your change would break a few boards...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's an old story about the person who wished his computer were as
easy to use as his telephone. That wish has come  true,  since  I  no
longer know how to use my telephone.