[U-Boot] [PATCH V3 1/5] pxa: move i2c driver to the common place

[Lei Wen]

Hi Prafulla,

On Tue, Mar 22, 2011 at 7:42 PM, Prafulla Wadaskar <prafulla at marvell.com> wrote:
>
>
>> -----Original Message-----
>> From: Lei Wen [mailto:leiwen at marvell.com]
>> Sent: Thursday, March 17, 2011 12:15 PM
>> To: Heiko Schocher; Wolfgang Denk; Prafulla Wadaskar; u-
>> boot at lists.denx.de; Marek Vasut; Ashish Karkare; Prabhanjan Sarnaik;
>> adrian.wenl at gmail.com
>> Subject: [PATCH V3 1/5] pxa: move i2c driver to the common place
>>
>> For better sharing with other platform other than pxa's,
>> it is more convenient to put the driver to the common place.
>>
>> Signed-off-by: Lei Wen <leiwen at marvell.com>
>> ---
>> Changelog:
>> v2: rename previous pxa_i2c to mvi2c.
>>
>> V3: change previous name from pxa_i2c to mv_i2c
>>     clean code style issue exist in original code
>>
>>  arch/arm/cpu/pxa/Makefile |    1 -
>>  arch/arm/cpu/pxa/i2c.c    |  469 --------------------------------------
>> -------
>>  drivers/i2c/Makefile      |    1 +
>>  drivers/i2c/mv_i2c.c      |  452
>> +++++++++++++++++++++++++++++++++++++++++++
>>  include/configs/innokom.h |    1 +
>>  include/configs/xm250.h   |    1 +
>>  6 files changed, 455 insertions(+), 470 deletions(-)
>>  delete mode 100644 arch/arm/cpu/pxa/i2c.c
>>  create mode 100644 drivers/i2c/mv_i2c.c
>
>
> ...snip...
>
>> -#endif       /* CONFIG_HARD_I2C */
>> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
>> index 052fe36..00a12cc 100644
>> --- a/drivers/i2c/Makefile
>> +++ b/drivers/i2c/Makefile
>> @@ -29,6 +29,7 @@ COBJS-$(CONFIG_BFIN_TWI_I2C) += bfin-twi_i2c.o
>>  COBJS-$(CONFIG_DRIVER_DAVINCI_I2C) += davinci_i2c.o
>>  COBJS-$(CONFIG_FSL_I2C) += fsl_i2c.o
>>  COBJS-$(CONFIG_I2C_MVTWSI) += mvtwsi.o
>> +COBJS-$(CONFIG_I2C_MV) += mv_i2c.o
>
> Mvtwsi and mv_i2c are two i2c drivers for Marvell.
> Can you merge these two?

As I explain to you before. Although kirkwood and pxa series are both
the product
of Marvell, but it don't necessary means that they must have the same controller
for both product line. For the i2c part, they just use two different controller.
So why you keep request merge those two? Do you mean you want to
create a unique I2C
framework for whole i2c drivers in drivers/i2c?

Best regards,
Lei