[U-Boot] [PATCH v6 12/13] nds32/ag101/adp-ag101: add board adp-ag101 support

[Wolfgang Denk]

Dear "Macpaul Lin",

In message <1300969687-2428-12-git-send-email-macpaul at andestech.com> you wrote:
> Add adp-ag101.c board config and related settings.
> 
> Signed-off-by: Macpaul Lin <macpaul at andestech.com>
> ---
>  MAINTAINERS                           |   11 +++++
>  MAKEALL                               |    6 +++
>  board/AndesTech/adp-ag101/Makefile    |   51 +++++++++++++++++++++
>  board/AndesTech/adp-ag101/adp-ag101.c |   81 
> +++++++++++++++++++++++++++++++++
>  board/AndesTech/adp-ag101/config.mk   |   27 +++++++++++
>  5 files changed, 176 insertions(+), 0 deletions(-)
>  create mode 100644 board/AndesTech/adp-ag101/Makefile
>  create mode 100644 board/AndesTech/adp-ag101/adp-ag101.c
>  create mode 100644 board/AndesTech/adp-ag101/config.mk
...
> diff --git a/board/AndesTech/adp-ag101/config.mk 
> b/board/AndesTech/adp-ag101/config.mk
> new file mode 100644
> index 0000000..2cee594
> --- /dev/null
> +++ b/board/AndesTech/adp-ag101/config.mk
...
> +PLATFORM_RELFLAGS += -gdwarf-2

This should go into a generic config.mk file, it is not board
specific.

> +CONFIG_SYS_TEXT_BASE = 0x03200000
> +LDSCRIPT := $(SRCTREE)/arch/$(ARCH)/cpu/$(CPU)/u-boot.lds

These should go into your board config file instead.

> +EXTERN_LIB += $(shell $(CC) -print-file-name=include)/../static/el/libgcc.a

Why would that be needed? 

Please fix so that you can get rid of board specific config.mk files.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Disc space - the final frontier!