[U-Boot] [PATCH v6 01/13] nds32: add header files support for nds32

[Macpaul Lin]

Hi Wolfgang,

2011/3/25 Wolfgang Denk <wd at denx.de>:
> Dear Macpaul Lin,
>
> please keep the list on Cc:
>
>> I did run checkpatch,
>> However, "some of these files" comes from Linux kernel header.
>
> Well, the checkpatch comes from Linux, so your files violate the Linux
> kernel coding style in the first place.  The should have never been
> accepted there.
>
>> And those files in Linux Kernel comes from arm's assembly headers.
>
> Well, that's not exactly a recommendation, if you ask me.
>
>> If I cleaned up these headers, it might cause some diffculty when those header
>> has been update in the kernel. After I disscussed with my colledgue
>> (Linux Kernel Team).
>> They wish me to send the headers with Linux kernel compatibilty.
>
> I suggect you clean up the header files in the Linux kernel as well.
> As it is a clear code cleanup (making the code match the Linux
> CodingStyle requirements) this should go in easily.
>
>> However it might require your confirmation so that I can let my boss
>> aware the headers will be different from those in Linux Kernel.
>
> I don't ask that they are different. On contrary, they should be
> identical if possible.  Here that means that the cleaned up versions
> should be used both in Linux and in U-Boot.
>
> Note: this also and especially applies to the "volatile" and "using
> I/O accessors instead of pointer acesses" issues. [If not yet, you
> would probably soon run into issues when switching to GCC 4.5.x or
> even GCC 4.6.]
>
> Best regards,
>
> Wolfgang Denk

Thanks for your suggestions.
I've forward it to the OS team of my company and inform them the
possible problem in the future.
Thanks a lot.

-- 
Best regards,
Macpaul Lin