[U-Boot] [PATCH v2 3/5] MIPS: Optimize the setup of endianess and CPU optimization flags

[Shinya Kuribayashi]

Sorry for being late,

On 03/24/2011 01:37 AM, Daniel Schwierzeck wrote:
> 2011/3/23 Shinya Kuribayashi <skuribay at pobox.com>:
> Following changes have been introduced to ld in binutils-2.16:
[...]
> I'd claim that all toolchains with binutils lesser than 2.16 are not
> working anymore.
[...]
>>> I suggest to drop official support for ELDK-3.1.1 / binutils-2.14 and
>>> earlier.

Excellent, no comments from me.  Let's forget about all pre-binutils
2.16 releases from now on, and ELDK-3.1.1 as well.

> I have prepared a v3 of this patch that checks whether -mips32r2 is
> supported. If not than -mips32 will be used as fallback. But I want
> to clarify this first before I send it.

I'm guessting you're worried that the corresponding line will differ
from what the Linux/MIPS has, but that's not a problem.  The Linux/MIPS
tries to tighten the condition in accordance with explicit configuration
options such as CONFIG_CPU_MIPS32_R1/R2, CONFIG_CPU_MIPS64_R1/R2.

> cflags-$(CONFIG_CPU_MIPS32_R1)	+= $(call cc-option,-march=mips32,-mips32 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
> 			-Wa,-mips32 -Wa,--trap
> cflags-$(CONFIG_CPU_MIPS32_R2)	+= $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
> 			-Wa,-mips32r2 -Wa,--trap
> cflags-$(CONFIG_CPU_MIPS64_R1)	+= $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) \
> 			-Wa,-mips64 -Wa,--trap
> cflags-$(CONFIG_CPU_MIPS64_R2)	+= $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) \
> 			-Wa,-mips64r2 -Wa,--trap

We U-Boot doesn't have to follow this convention, and can relax the cc-
option rules.

I'll wait for v3 patch(es), and push them during the next merge window.
Thanks in advance,