[U-Boot] [PATCH v2 5/6] netconsole: remove `serverip' check

[Wolfgang Denk]

Dear Simon Guinot,

In message <1304284220-15215-6-git-send-email-sguinot at lacie.com> you wrote:
> Netconsole use the environment variable `ncip' to configure the
> destination IP. `serverip' don't need to be defined.
> 
> Signed-off-by: Simon Guinot <sguinot at lacie.com>
> ---
>  net/net.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/net.c b/net/net.c
> index e50bdf1..5bf3c8c 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1718,7 +1718,6 @@ static int net_check_prereq (proto_t protocol)
>  #if defined(CONFIG_CMD_NFS)
>  	case NFS:
>  #endif
> -	case NETCONS:
>  	case TFTP:
>  		if (NetServerIP == 0) {
>  			puts ("*** ERROR: `serverip' not set\n");
> @@ -1729,6 +1728,7 @@ static int net_check_prereq (proto_t protocol)
>      common:
>  #endif
>  
> +	case NETCONS:

Please add a "/* fall through */" comment before the case label, so it
is clear to the reader that this is intended behaviour.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
They're usually so busy thinking about what  happens  next  that  the
only  time they ever find out what is happening now is when they come
to look back on it.                 - Terry Pratchett, _Wyrd Sisters_