[U-Boot] [PATCH 6/6] Add support for Network Space v2

[Prafulla Wadaskar]

> -----Original Message-----
> From: Simon Guinot [mailto:simon.guinot at sequanux.org]
> Sent: Sunday, May 01, 2011 8:34 PM
> To: Prafulla Wadaskar; Albert ARIBAUD
> Cc: u-boot at lists.denx.de; Simon Guinot
> Subject: [PATCH 6/6] Add support for Network Space v2
> 
> From: Simon Guinot <sguinot at lacie.com>
> 
> This patch add support for the Network Space v2 board and parents.
> This include Network Space (Max) v2 and Internet Space v2.

It's good it you can provide any pointer for board information if any.

> 
> Signed-off-by: Simon Guinot <sguinot at lacie.com>
> ---
>  Makefile                              |    7 ++
>  board/LaCie/netspace_v2/Makefile      |   49 ++++++++++
>  board/LaCie/netspace_v2/kwbimage.cfg  |  162
> +++++++++++++++++++++++++++++++++
>  board/LaCie/netspace_v2/netspace_v2.c |  150
> ++++++++++++++++++++++++++++++
>  board/LaCie/netspace_v2/netspace_v2.h |   39 ++++++++
>  include/configs/netspace_v2.h         |  142
> +++++++++++++++++++++++++++++
>  6 files changed, 549 insertions(+), 0 deletions(-)
>  create mode 100644 board/LaCie/netspace_v2/Makefile
>  create mode 100644 board/LaCie/netspace_v2/kwbimage.cfg
>  create mode 100644 board/LaCie/netspace_v2/netspace_v2.c
>  create mode 100644 board/LaCie/netspace_v2/netspace_v2.h
>  create mode 100644 include/configs/netspace_v2.h

I hope these are not clone from existing supported board.
If you have 80% similarities, you can use the same source code.

> 
> diff --git a/Makefile b/Makefile
> index ada951e..18e6ecd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -897,6 +897,13 @@ TNY_A9260_config	:	unconfig
>  	@echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h
>  	@$(MKCONFIG) -n $@ -a tny_a9260 arm arm926ejs tny_a9260 calao at91
> 
> +inetspace_v2_config	\
> +netspace_v2_config	\
> +netspace_max_v2_config	:	unconfig
> +	@mkdir -p $(obj)include
> +	@echo "#define CONFIG_$(shell echo $(@:_config=) | tr 'a-z' 'A-Z')
> 1" >$(obj)include/config.h
> +	@$(MKCONFIG) -n $@ -a netspace_v2 arm arm926ejs netspace_v2 LaCie
> kirkwood
> +
> 

Please refer better way of doing it.
Ref boards.cfg file in : http://lists.denx.de/pipermail/u-boot/2011-April/091368.html

Regards..
Prafulla . .