[U-Boot] [PATCH 2/2] powerpc/85xx: verify the device tree before booting Linux

Kumar Gala galak at kernel.crashing.org
Tue May 3 17:10:18 CEST 2011


On May 3, 2011, at 9:41 AM, Timur Tabi wrote:

> On May 3, 2011, at 9:21 AM, Kumar Gala <galak at kernel.crashing.org> wrote:
> 
>>> 
>>> +
>>> +        ft_verify_fdt(*of_flat_tree);
>> 
>> Do we not want to error out here if verify fails?
> 
> Maybe.  I didn't want a false negative to prevent booting.  If the DT is wrong, the kernel won't display any messages, so the warning will be the last thing the user sees anyway.
> 
> If the consensus is that failure should abort, then I can add that.  I don't have a strong preference either way.
>> 

I would think that a verify of this form should be considered as bad as not passing a checksum verification.

- k


More information about the U-Boot mailing list