[U-Boot] [PATCH V2 1/2] GPIO: Tegra2: add GPIO driver for Tegra2

Mike Frysinger vapier at gentoo.org
Tue May 3 21:29:43 CEST 2011


On Tue, May 3, 2011 at 12:49, Michael Walle wrote:
> Am Di, 3.05.2011, 00:45, schrieb Tom Warren:
>> Changes in V2:
>>       - use 'gpio_pin' enum in gpio.h (Simon Glass review request)
>>       - change 'GPIO_PORT8' to 'GPIO_FULLPORT' (Simon Glass request)
>>       - change 'offset' to 'pin' globally
>>
>>  arch/arm/include/asm/arch-tegra2/gpio.h |  244
> ++++++++++++++++++++++++-
>>  drivers/gpio/Makefile                   |    1 +
>>  drivers/gpio/tegra2_gpio.c              |  299
>
> Does this (SoC) driver belong to drivers/gpio/ or
> arch/arm/cpu/armv7/tegra2/? To me it seems that both are used for
> architectures/SoCs specific drivers (eg. blackfin, omap in arch/ and at91
> in drivers/gpio/). What is the preferred directory?

following the Linux style makes sense to me.  only gpio expanders and
such live in drivers/gpio/.  but until we get a more unified api
effort, i'm not sure sweating the location of the driver is important.
-mike


More information about the U-Boot mailing list