[U-Boot] [PATCH v2 6/8] arm/km: rename mgcoge2un to mgcoge3un

[Valentin Longchamp]

Prafulla Wadaskar wrote:
> 
>> -----Original Message-----
>> From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
>> Sent: Tuesday, May 03, 2011 7:43 PM
>> To: u-boot at lists.denx.de
>> Cc: Prafulla Wadaskar; holger.brunck at keymile.com; Valentin Longchamp;
>> Wolfgang Denk; Detlev Zundel
>> Subject: [PATCH v2 6/8] arm/km: rename mgcoge2un to mgcoge3un
>>
>> From: Holger Brunck <holger.brunck at keymile.com>
>>
>> The mgcoge2un target was only an intermediate step to mgcoge3un.
>> For this reason the mgcoge2un support was moved to mgcoge3un,
>> because it isn't needed to support both targets.
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp at keymile.com>
>> Signed-off-by: Holger Brunck <holger.brunck at keymile.com>
>> Acked-by: Heiko Schocher <hs at denx.de>
>> cc: Prafulla Wadaskar <prafulla at marvell.com>
>> cc: Wolfgang Denk <wd at denx.de>
>> cc: Detlev Zundel <dzu at denx.de>
>> ---
>> Changes for v2:
>>    - split up first large patch series to three independent smaller
>>      patch series
>>
>>  MAINTAINERS                                  |    8 ++++----
>>  boards.cfg                                   |    2 +-
>>  include/configs/{mgcoge2un.h => mgcoge3un.h} |   10 +++++-----
>>  3 files changed, 10 insertions(+), 10 deletions(-)
>>  rename include/configs/{mgcoge2un.h => mgcoge3un.h} (92%)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e2a4ba9..2dd1f8d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -429,14 +429,11 @@ Heiko Schocher <hs at denx.de>
>>  	kmeter1		MPC8360
>>  	kmsupx5		MPC8321
>>  	mgcoge		MPC8247
>> -	mgcoge2ne	MPC8247
>> -	mgcoge2un	ARM926EJS (Kirkwood SoC)
>> +	mgcoge3ne	MPC8247
>>  	mucmc52		MPC5200
>>  	muas3001	MPC8270
>>  	municse		MPC5200
>>  	sc3		PPC405GP
>> -	suen3		ARM926EJS (Kirkwood SoC)
>> -	suen8		ARM926EJS (Kirkwood SoC)
>>  	suvd3		MPC8321
>>  	tuda1		MPC8321
>>  	tuxa1		MPC8321
>> @@ -814,6 +811,9 @@ Jens Scharsig <esw at bus-elektronik.de>
>>  Heiko Schocher <hs at denx.de>
>>
>>  	magnesium	i.MX27
>> +	mgcoge3un	ARM926EJS (Kirkwood SoC)
>> +	suen3		ARM926EJS (Kirkwood SoC)
>> +	suen8		ARM926EJS (Kirkwood SoC)
>>
>>  Robert Schwebel <r.schwebel at pengutronix.de>
>>
>> diff --git a/boards.cfg b/boards.cfg
>> index 2b0900a..2d36c52 100644
>> --- a/boards.cfg
>> +++ b/boards.cfg
>> @@ -105,7 +105,7 @@ davinci_sffsdr               arm         arm926ejs
>> sffsdr              davinci
>>  davinci_sonata               arm         arm926ejs   sonata
>> davinci        davinci
>>  suen3                        arm         arm926ejs   km_arm
>> keymile        kirkwood
>>  suen8                        arm         arm926ejs   km_arm
>> keymile        kirkwood
>> -mgcoge2un                    arm         arm926ejs   km_arm
>> keymile        kirkwood
>> +mgcoge3un                    arm         arm926ejs   km_arm
>> keymile        kirkwood
>>  guruplug                     arm         arm926ejs   -
> 
> How are you addressing builds different boards in the same code?
> You can have some common code using features of boards.cfg
> Check top comments in boards.cfg
> 

This is a discussion we have already had for our ppc boards 
(http://lists.denx.de/pipermail/u-boot/2011-May/091873.html).

The current differences between our kirkwood boards are not many, but 
since we have new boards coming where the difference number is going to 
grow, it is going to be hard to keep many (even 2) boards in one single 
file. That why we prefer to have the differences (and common source code 
we have to maintain, I agree as well) in .h source files than in the 
boards.cfg file.

Regards

-- 
Valentin Longchamp
Embedded Software Engineer
Hardware and Chip Integration
______________________________________
KEYMILE AG
Schwarzenburgstr. 73
CH-3097 Liebefeld
Phone +41 31 377 1318
Fax   +41 31 377 1212
valentin.longchamp at keymile.com
www.keymile.com
______________________________________
KEYMILE: A Specialist as a Partner