[U-Boot] [PATCH v2 3/8] arm/km: add BootROM config file for memphis SDRAM

[Wolfgang Denk]

Dear Valentin Longchamp,

In message <4DC1092E.4080804 at keymile.com> you wrote:
>
> > You are just adding file here, whereas it is not being used. Is it like dead code to me.
> 
> Yes, it is not used with the u-boot build system, we have a small script 
> that wraps around it.

As this "small script" is neither available here this _is_ dead code
and will not be accepted.


> It is used by the mgcoge3un board, that is later introduced with this 
> series.

Then please add it together with this board, then.

> Now I have a question about the marvell boards build: I see in the 
> Makefile that there is a rule about this kwb file, which is exactly what 
> we do in our additionnal build script:

Please either get rid of this "additionnal build script", or move it's
function into the mainline U-Boot code.

(Note: this might even be considered as a GPL violation which
requires to include "scripts used to control compilation").


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No question is too silly to ask. Of course, some  questions  are  too
silly to to answer...  - L. Wall & R. L. Schwartz, _Programming Perl_