[U-Boot] [PATCH v2] PPC405EX CHIP_21 erratum

[Stefan Roese]

Hi Steve,

On Wednesday 04 May 2011 16:53:50 Steven A. Falco wrote:
> v2:
> Correct checkpatch errors/warnings re: whitespace, comment style, etc.
> Move PVR logic out of board config file.
> Simplify ifdef structure.

Those comments above below below the "---" line of the patch. This way they 
will not be included in the git history.
 
> APM errata CHIP_21 for the 405EX/EXr (from the rev 1.09 document dated
> 4/27/11) states that rev D processors may wake up with the wrong feature
> set.  I've personally seen that happen.  This patch implements the
> APM-proposed workaround.
> 
> To enable this patch for your board, add the appropriate define for your
> CPU to your board header file.  See kilauea.h for an example.  The
> following variants are supported:
> 
> #define CONFIG_SYS_4xx_CHIP_21_405EX_NO_SECURITY
> #define CONFIG_SYS_4xx_CHIP_21_405EX_SECURITY
> #define CONFIG_SYS_4xx_CHIP_21_405EXr_NO_SECURITY
> #define CONFIG_SYS_4xx_CHIP_21_405EXr_SECURITY

I'm wondering how boards should handle this, when they can be equipped with 
all 405EX(r) variants. Like Kilauea/Haleakala. For Kilauea (405EX) / Haleakala 
(405EXr) only one U-Boot binary is generated and used on both boards. And 
IIRC, they can be equipped with both chip versions, with and without security. 
Do you have any ideas on how this could be handled.

<snip>

> diff --git a/include/configs/kilauea.h b/include/configs/kilauea.h
> index 031f8fb..2be1104 100644
> --- a/include/configs/kilauea.h
> +++ b/include/configs/kilauea.h
> @@ -44,6 +44,12 @@
>  #endif
> 
>  /*
> + * CHIP_21 errata - you must set this to match your CPU, else the board
> + * will not boot.
> + */
> +#define CONFIG_SYS_4xx_CHIP_21_405EX_NO_SECURITY

As long as we don't have a "solution" for handling 405EX & 405EXr SoC's in a 
single binary, we shouldn't add this errata-fix to kilauea.h.

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de