[U-Boot] [PATCH v6 4/5] Put common autoload code into auto_load() function

Simon Glass sjg at chromium.org
Thu May 5 22:08:09 CEST 2011


On Thu, May 5, 2011 at 12:48 PM, Wolfgang Denk <wd at denx.de> wrote:

> Dear Mike Frysinger,
>
> > put the TftpStart into a new else, then there's no need for the inline
> > "return" ...
>
> I disagree here.  As is, we save one level of nesting, which is
> always a good thing.
>
> On contrary, the "else" in the CONFIG_CMD_NFS should be dropped as
> well, i. e. let's make this:
>


> ...
>
> Best regards,
>
> Wolfgang Denk
>

OK I will do that instead.

Regards,
Simon


>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "We learn from history that we learn nothing from history."
> - George Bernard Shaw
>


More information about the U-Boot mailing list