[U-Boot] [PATCH] nand_spl: nand_boot.c: Init nand_chip.options to 0

Stefan Roese sr at denx.de
Fri May 6 15:12:18 CEST 2011


On Wednesday 04 May 2011 19:30:29 Scott Wood wrote:
> > +	nand_chip.options = 0;
> >  	board_nand_init(&nand_chip);
> >  	
> >  	if (nand_chip.select_chip)
> 
> Maybe nand_chip should be made static so it goes in the BSS?  This would
> avoid any other such problems, without adding any extra code to zero things
> out.

Yes, good idea. I tried it but it resulted in a bigger image instead of a 
smaller one. I need to investigate further to see why this is the case...

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list