[U-Boot] [PATCH v2 0/8] net/net.c: cleanups for checkpatch compliance

Luca Ceresoli luca.ceresoli at comelit.it
Wed May 11 15:59:53 CEST 2011


Hi,

this is an update to the net/net.c cleanup, incorporating Mike's suggestions
to patches 1 and 2. Thanks Mike.

net/net.c currently raises a lot of checkpatch issues: 76 errors, 197 warnings.
This patchset fixes most of them, leaving 0 errors and 27 warnings.

Since the changes are quite massive I split them in separate patches, one
per each category of errors/warning.

The warnings that are still present are of the following types:
 - WARNING: consider using kstrto* in preference to simple_strtoul
   which is Linux-specific;
 - WARNING: externs should be avoided in .c files
   these are due to loop-dependencies between net/net.c and other files;
 - WARNING: line over 80 characters
   described in the commit message for patch 1;
 - WARNING: Use of volatile is usually wrong [...]
   I've had a quick look at these, but I don't know in detail how the
   networking code and Ethernet drivers (and maybe DMA?) interact, so I cannot
   remove them being sure that things will continue working.

Luca


Luca Ceresoli (8):
  net/net.c: cosmetic: fix lines over 80 characters
  net/net.c: cosmetic: variable initializations
  net/net.c: cosmetic: fix whitespace issues
  net/net.c: cosmetic: fix brace issues
  net/net.c: cosmetic: fix pointer syntax issues
  net/net.c: cosmetic: parentheses not required for return
  net/net.c: cosmetic: fix indentation
  net/net.c: cosmetic: do not use assignment in if condition

 net/net.c |  593 ++++++++++++++++++++++++++++++++++---------------------------
 1 files changed, 328 insertions(+), 265 deletions(-)



More information about the U-Boot mailing list